Implement Optional Parameters to include and exclude submodules by MrBanana05 · Pull Request #620 · mojohaus/license-maven-plugin (original) (raw)

@MrBanana05

Solves #553

I've added optional configuration parameters to include or exclude certain submodules. This is really handy in bigger projects with a lot of modules. We're already using this feature in our monorepo with easily over 150 modules.

If neither of the properties are set, all modules will be included in the analysis. It does not introduce any breaking changes.

@MrBanana05

Hey @slawekjaranowski, I don't want to be rude but I saw that you've worked on the other PR and just wanted to make sure you didn't miss mine. As I said, we're already using this but we'd love to go back to the official version of the plugin and get rid of our fork. Please let me know if there's anything I should do to get this PR merged, thank you!

@slawekjaranowski

A unit tests and at least one IT - will be appreciated

@MrBanana05

@MrBanana05

Hi, thanks for the feedback! I finally found some time to write the tests. Please let me know if you need anything else.

@MrBanana05

Hey @slawekjaranowski, again, I don't want to be rude, I just wanted to ask whether you had the time to take a look at this PR and the tests I've added. Please let me know if you need anything else. Thank you!

@slawekjaranowski

slawekjaranowski

* @since 2.6.0
*/
@Parameter(property = "license.includedModules")
private String[] includedModules;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be List<String> but it is no issue

slawekjaranowski

@slawekjaranowski

@slawekjaranowski

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})