Remove banner name from site descriptor by slawekjaranowski · Pull Request #565 · mojohaus/mojo-parent (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

mojohaus / mojo-parent Public

Additional navigation options

Merged

slawekjaranowski

merged 1 commit into

masterfrom

banner-name

Sep 14, 2024

ConversationCommits (1)ChecksFiles changed

Merged

Remove banner name from site descriptor#565

slawekjaranowski

merged 1 commit into

masterfrom

banner-name

Conversation

@slawekjaranowski

@slawekjaranowski slawekjaranowski commented

Sep 14, 2024

Copy link Copy Markdown

Member

In old version of skin banner.name was used as image alt

Now banner.name is always print - remove it to make site looks the same as current.

@slawekjaranowski

`[Remove banner name from site descriptor](/mojohaus/mojo-parent/pull/565/commits/a644d07ee698f5996c2cedc9d7b1587299101e51 "Remove banner name from site descriptor

In old version of skin banner.name was used as image alt") `

[a644d07](/mojohaus/mojo-parent/pull/565/commits/a644d07ee698f5996c2cedc9d7b1587299101e51)

In old version of skin banner.name was used as image alt

@slawekjaranowski slawekjaranowski added maintenance bug and removed maintenance labels

Sep 14, 2024

@slawekjaranowski slawekjaranowski requested a review from michael-o

September 14, 2024 20:03

michael-o

michael-o approved these changes Sep 14, 2024

View reviewed changes

@slawekjaranowski slawekjaranowski merged commit 301f456 into master

Sep 14, 2024

@slawekjaranowski slawekjaranowski deleted the banner-name branch

September 14, 2024 20:47

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slawekjaranowski @michael-o