fix(#3817): send servername for SNI on TLS (#3821) [backport] by metcoder95 · Pull Request #3864 · nodejs/undici (original) (raw)

Conversation

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

• fix(#3817): send servername for SNI on TLS

• fix: set host header to servername

• refactor: attach regardless

(cherry picked from commit b93a834)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we didn't backport dns interceptor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak deleted the backport-3821-to-v6.x branch

December 31, 2024 18:19

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

2 participants