fix windows CI by KhafraDev · Pull Request #2379 · nodejs/undici (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Merged
merged 2 commits into
Oct 26, 2023
Conversation
yeah so that works, I have no idea why removing the options passed to node would matter, but...
kodiakhq Bot referenced this pull request in X-oss-byte/Canary-nextjs
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
FYI This PR has removed websockets from the WPT report again.
And adding the --experimental-websocket option to your npm script will not work because presence of that option will make the daily WPT job error on older versions of node where the option didn't land.
why did we need the flag?
To allow detecting that the feature was present on a particular node build that's being used in the WPT job matrix. #2351
I think it can be replaced with a version check instead
I think it can be replaced with a version check instead
If you want to maintain that, sure, I didn't.
This was referenced
Nov 7, 2023
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
kodiakhq Bot referenced this pull request in ascorbic/unpic-img
renovate Bot referenced this pull request in specfy/specfy
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
gr2m referenced this pull request in octokit/rest.js
kodiakhq Bot referenced this pull request in X-oss-byte/Nextjs
crysmags pushed a commit to crysmags/undici that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})