Fix suppression handling when 'formatter:on' not properly specified by paul-dingemans · Pull Request #2719 · ktlint/ktlint (original) (raw)

Description

Fix suppression handling when 'formatter:on' not properly specified

If the 'formatter:on' tag is not specified in the same scope as the 'formatter:off' tag, then the IndentationRule might throw an exception as the IndentationContextStack is not properly cleaned.

Also, cleaned up of CommentSuppressionHint.EOL type as it was not used since replacing the EOL suppression hints in 1.0 release.

Closes #2695

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

• Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
• At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
• Tests are added
• KtLint format has been applied on source code itself and violations are fixed
• PR title is short and clear (it is used as description in the release changelog)
• PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

• Snapshot documentation in case documentation is to be released together with a code change
• Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master