chore: update ESLint to v9 by fisker · Pull Request #709 · prettier/eslint-plugin-prettier (original) (raw)

@fisker

@changeset-bot

fisker

fisker

fisker

@fisker

@fisker fisker marked this pull request as ready for review

March 6, 2025 13:17

@JounQin

Seems only housekeeping, but Node 14/16 compatible tests are disabled?

@fisker

@JounQin

@fisker

We may need to downgrade eslint to v8 for Node 14/16 on CI?

I can try, but do we have a plan to drop support? Since I didn't actually change the code, it should still work with ESLint 8, just not tested.

@JounQin

I can try, but do we have a plan to drop support? Since I didn't actually change the code, it should still work with ESLint 8, just not tested.

Personally I'd follow prettier's strategy instead of eslint's.

What means when prettier changes its engines support, eslint-plugin-prettier will follow.

@fisker fisker marked this pull request as draft

March 6, 2025 14:26

@fisker

@fisker fisker marked this pull request as ready for review

March 6, 2025 15:17

JounQin

@fisker

@fisker

JounQin

@JounQin

@JounQin

Thanks for your great work!

@zyv zyv mentioned this pull request

Mar 15, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})