Fix third-party workflow by AlexWaygood · Pull Request #269 · python/typing_extensions (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

pdm now won't let us add the main branch of typing_extensions as a dependency to pydantic or cattrs, because they both still have requires-python = ">= 3.7" in their pyproject.toml files, and we now have requires-python = ">= 3.8" in ours. To me it seems silly that pdm's locking mechanism is working this way, since we're not trying to actually install or run pydantic or cattrs on Python 3.7. But anyway, here's a hacky workaround to get things green again.

Fixes #268

To me it seems silly that pdm's locking mechanism is working this way, since we're not trying to actually install or run pydantic or cattrs on Python 3.7.

Oh, I guess it's so that pip install pydantic is guaranteed to come with the same version of typing_extensions for any given version of pydantic, meaning that you get fully reproducible installs. I guess that makes sense. Still annoying for us, though.

2 participants