Use Http2SslContextSpec to build SslContext when http2 enabled by ashraf-revo · Pull Request #2764 · reactor/reactor-netty (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ashraf-revo

Iam getting error when try to run http2 on Netty examples
I found that it uses Http11SslContextSpec to generate certificates for both http11 and http2 which should use Http2SslContextSpec for http2

ashraf added 2 commits

April 4, 2023 19:22

violetagg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks

@violetagg

@violetagg violetagg changed the titleuse Http2SslContextSpec to build ssl context when http2 enabled Use Http2SslContextSpec to build SslContext when http2 enabled

Apr 4, 2023

pderop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR.

violetagg added a commit that referenced this pull request

Apr 5, 2023

@violetagg

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels