Add tests to check data CRC by jongiddy · Pull Request #527 · rust-lang/flate2-rs (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot everyone! I'd merge this.

However, please allow one last question: could these tests be in tests/ as they don't use private APIs? It looks like it, and I would have checked (and possibly done) the move myself but then I can't merge it anymore 😅.

Then again, as this doesn't introduce tests, we could also move the tests over, if possible, in a separate PR and call this one done enough.