Fix const for field tm_zone in struct tm by semarie · Pull Request #4948 · rust-lang/libc (original) (raw)

Conversation

Description

The PR makes the CI to ignore tm_zone field in struct tm. The const has been recently added in OpenBSD (see sources).

The another way is to properly define struct tm in OpenBSD, and move the currently global definition to each unix platform. It might be preferable. Feel free to ask for this way 😃

Sources

• openbsd/src@4a796cf
• https://github.com/openbsd/src/blob/7a3d6f69f0a9b1766a54f549b550113ea4d460f1/include/time.h#L98

Checklist

• Relevant tests in libc-test/semver have been updated
• No placeholder or unstable values like *LAST or *MAX are
  included (see #3131)
• Tested locally (cd libc-test && cargo test --target mytarget);
  especially relevant for platforms that may not be checked in CI

The another way is to properly define struct tm in OpenBSD, and move the currently global definition to each unix platform. It might be preferable. Feel free to ask for this way 😃

If it doesn't confuse downstream users, I'd prefer! I'm not sure but OpenBSD 7.8 doesn't have it yet?

the change (on OpenBSD side) is for upcoming OpenBSD-7.9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Merged via the queue into rust-lang:main with commit 7be4e60

Jan 28, 2026

50 of 51 checks passed

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request

Feb 9, 2026

tgross35 added stable-applied

This PR has been cherry-picked to libc's stable release branch

and removed stable-nominated

This PR should be considered for cherry-pick to libc's stable release branch

labels

Feb 9, 2026

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels