Minor grammar tweaks by jsoref · Pull Request #1393 · sirupsen/logrus (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

sirupsen / logrus Public

• Notifications You must be signed in to change notification settings

• Fork2.3k

• Star 25.7k

• Code

• Issues 7

• Pull requests 49

• Actions

• Projects

• Wiki

• Security and quality

• Insights

Additional navigation options

Merged

thaJeztah

merged 1 commit into

sirupsen:masterfrom

jsoref:grammar

Aug 4, 2025

ConversationCommits (1)ChecksFiles changed

Merged

Minor grammar tweaks#1393

thaJeztah

merged 1 commit into

sirupsen:masterfrom

jsoref:grammar

Conversation

jsoref commented

Jun 21, 2023

Copy link Copy Markdown

Contributor

• Syslog hooks are a group, Syslog hook parses as noun+verb
• Third-party and built-in are hyphenated things...
• shut down is a verb-phrase, shutdown is the noun

[Minor grammar tweaks](/sirupsen/logrus/pull/1393/commits/1baa4319b6f78eeb10fd53757f7f7b2930bb1c7c "Minor grammar tweaks")

[1baa431](/sirupsen/logrus/pull/1393/commits/1baa4319b6f78eeb10fd53757f7f7b2930bb1c7c)

thaJeztah approved these changes Aug 4, 2025

View reviewed changes

thaJeztah left a comment

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

thaJeztah merged commit 55cf256 into sirupsen:master

Aug 4, 2025

jsoref deleted the grammar branch

August 4, 2025 19:16

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants