Support SameSite cookie attribute in MockMvcHttpConnector by justin-tay · Pull Request #30264 · spring-projects/spring-framework (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

spring-projects / spring-framework Public

• Notifications You must be signed in to change notification settings

• Fork38.8k

• Star 60k

• Code

• Issues 343

• Pull requests 109

• Actions

• Wiki

• Security and quality

• Insights

Additional navigation options

Closed

justin-tay

wants to merge 1 commit into

spring-projects:mainfrom

justin-tay:mockmvchttpconnector-samesite

ConversationCommits (1)ChecksFiles changed

Closed

Support SameSite cookie attribute in MockMvcHttpConnector#30264

justin-tay

wants to merge 1 commit into

spring-projects:mainfrom

justin-tay:mockmvchttpconnector-samesite

Conversation

justin-tay commented

Apr 1, 2023

Copy link Copy Markdown

Contributor

Modified MockMvcHttpConnector to set sameSite using Cookie.getAttribute.

The test relies on MockCookie setting the SameSite attribute to pass.

[Support SameSite attribute in MockMvcHttpConnector](/spring-projects/spring-framework/pull/30264/commits/3a891929803feddbbbe2ccb2e8940f32cae6a207 "Support SameSite attribute in MockMvcHttpConnector")

[3a89192](/spring-projects/spring-framework/pull/30264/commits/3a891929803feddbbbe2ccb2e8940f32cae6a207)

spring-projects-issues added the status: waiting-for-triage

An issue we've not yet triaged or decided on

label

Apr 1, 2023

sbrannen changed the titleSupport SameSite attribute in MockMvcHttpConnector Support SameSite cookie attribute in MockMvcHttpConnector

Apr 1, 2023

sbrannen self-assigned this

Apr 1, 2023

sbrannen added in: web

Issues in web modules (web, webmvc, webflux, websocket)

type: enhancement

A general enhancement

status: blocked

An issue that's blocked on an external project change

labels

Apr 1, 2023

sbrannen commented

Apr 1, 2023

Copy link Copy Markdown

Member

• Blocked by Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes" #30263

sbrannen added this to the 6.0.8 milestone

Apr 1, 2023

sbrannen added in: test

Issues in the test module

and removed status: waiting-for-triage

An issue we've not yet triaged or decided on

labels

Apr 1, 2023

sbrannen mentioned this pull request

Apr 1, 2023

Fix SameSite attribute in MockMvcHttpConnector#30260

Closed

sbrannen removed the status: blocked

An issue that's blocked on an external project change

label

Apr 4, 2023

sbrannen mentioned this pull request

Apr 4, 2023

Introduce assertions against Cookie attributes in CookieResultMatchers for MockMvc #30285

Closed

3 tasks

sbrannen commented

Apr 4, 2023

Copy link Copy Markdown

Member

FYI: this PR inspired me to create #30285.

So thanks for that. 👍

sbrannen closed this in[dd97ee4](/spring-projects/spring-framework/commit/dd97ee4e99fe9e870e77c1257b1fdf822fb353ce)

Apr 4, 2023

sbrannen commented

Apr 4, 2023

Copy link Copy Markdown

Member

This has been merged into main.

Thanks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

sbrannen

Labels

in: test

Issues in the test module

in: web

Issues in web modules (web, webmvc, webflux, websocket)

type: enhancement

A general enhancement

Projects

None yet

Milestone

6.0.8

Development

Successfully merging this pull request may close these issues.

3 participants