fix: additional check for component on destroy (svelte4) by hardl · Pull Request #11489 · sveltejs/svelte (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub Copilot appDirect agents from issue to merge
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners

View all resources

• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * GitHub Stars
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

sveltejs / svelte Public

• Notifications You must be signed in to change notification settings

• Fork4.9k

• Star 87.3k

• Code

• Issues 931

• Pull requests 97

• Discussions

• Actions

• Projects

• Wiki

• Security and quality 13

• Insights

Additional navigation options

Merged

dummdidumm

merged 3 commits into

sveltejs:svelte-4from

hardl:ce-instance-check2

May 6, 2024

ConversationCommits (3)ChecksFiles changed

Merged

fix: additional check for component on destroy (svelte4)#11489

dummdidumm

merged 3 commits into

sveltejs:svelte-4from

hardl:ce-instance-check2

Conversation

hardl commented

May 6, 2024

Copy link Copy Markdown

Contributor

svelte 4 version of #11488
fix for #10454

gterras reacted with thumbs up emoji

[this.$$c may be undefined if element was removed from DOM right after…](/sveltejs/svelte/pull/11489/commits/fccccd4580a6328ad6f4158e33668e1d4718fac8 "this.$$c may be undefined if element was removed from DOM right after attaching")

[fccccd4](/sveltejs/svelte/pull/11489/commits/fccccd4580a6328ad6f4158e33668e1d4718fac8)

… attaching

changeset-bot Bot commented

May 6, 2024

•

edited

Loading

Copy link Copy Markdown

🦋 Changeset detected

Latest commit: dcca394

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm approved these changes May 6, 2024

View reviewed changes

dummdidumm left a comment •

edited

Loading

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you add a changeset? Then we're good to merge.

[added changeset](/sveltejs/svelte/pull/11489/commits/696afa5eb16d315280f68910f9a5201c3c66fbb7 "added changeset")

[696afa5](/sveltejs/svelte/pull/11489/commits/696afa5eb16d315280f68910f9a5201c3c66fbb7)

dummdidumm approved these changes May 6, 2024

View reviewed changes

Comment thread

.changeset/many-trainers-pretend.md Outdated

[Update .changeset/many-trainers-pretend.md](/sveltejs/svelte/pull/11489/commits/dcca3949f2adbb0d45215f431c7a8fabb2e73ebc "Update .changeset/many-trainers-pretend.md")

[dcca394](/sveltejs/svelte/pull/11489/commits/dcca3949f2adbb0d45215f431c7a8fabb2e73ebc)

dummdidumm merged commit 1bab571 into sveltejs:svelte-4

May 6, 2024

github-actions Bot mentioned this pull request

May 6, 2024

Version Packages#11491

Merged

ovx mentioned this pull request

Oct 10, 2024

fix: properly remove event listeners in Component's removeEventListener (v4)#13556

Merged

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants