⚙ D13757 [x86] promote 'add nsw' to a wider type to allow more combines (original) (raw)

This is an archive of the discontinued LLVM Phabricator instance.

Table of Contentst-llvm/trunk/-trunk/-lib/Target/X86/-Target/-X86/-X86ISelLowering.cpp-test/CodeGen/X86/-CodeGen/-X86/-add-nsw-sext.llHide PanelfKeyboard Reference? Differential D13757 Authored by spatel on Oct 14 2015, 4:51 PM.Download Raw DiffReviewers qcolombetchandlercmajnemersanjoyzansarihfinkel Commits rGbbd524496ccf: [x86] promote 'add nsw' to a wider type to allow more combinesrL250560: [x86] promote 'add nsw' to a wider type to allow more combines Repository rL LLVM Event Timelinespatel updated this revision to Diff 37416.spatel retitled this revision from to [x86] promote 'add nsw' to a wider type to allow more combines.spatel updated this object.spatel added reviewers: hfinkel, chandlerc, qcolombet, zansari.spatel added a subscriber: llvm-commits.Herald added a subscriber: aemerson. Comment ActionsComment ActionsComment Actionslib/Target/X86/X86ISelLowering.cpp 25702 ↗(On Diff #37416)Comment Actionsspatel added reviewers: sanjoy, majnemer.spatel added inline comments.lib/Target/X86/X86ISelLowering.cpp 25702 ↗(On Diff #37416)spatel mentioned this in D13740: Catch combine opportunities for redundant imuls.Comment Actionsqcolombet accepted this revision.qcolombet edited edge metadata.This revision is now accepted and ready to land.majnemer added inline comments.lib/Target/X86/X86ISelLowering.cpp 25702 ↗(On Diff #37416)Closed by commit rL250560: [x86] promote 'add nsw' to a wider type to allow more combines (authored by spatel). This revision was automatically updated to reflect the committed changes.Comment Actionsapilipenko mentioned this in D23359: [x86] X86ISelLowering zext(add_nuw(x, C)) --> add(zext(x), C_zext).spatel mentioned this in rL355118: [InstCombine] fold adds of constants separated by sext/zext.spatel mentioned this in rG4a47f5f55071: [InstCombine] fold adds of constants separated by sext/zext.FilesHistoryCommitsPathSizellvm/trunk/lib/Target/X86/X86ISelLowering.cpp54 linestest/CodeGen/X86/add-nsw-sext.ll38 linesDiffIDBaseDescriptionCreatedLintUnitBaseBaseDiff 137416Oct 14 2015, 3:57 PM★★Diff 237648250559Commit rL250560Oct 16 2015, 3:14 PM★★This file is larger than 256 KB, so syntax highlighting is disabled by default.