⚙ D144004 [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7) (original) (raw)

This is an archive of the discontinued LLVM Phabricator instance.

Table of Contentst-clang/test/CodeGenCXX/-test/-CodeGenCXX/-debug-info-namespace.cpp-llvm/-include/llvm/IR/-llvm/-IR/-DIBuilder.h-lib/-Bitcode/Reader/-Reader/-MetadataLoader.cpp-CodeGen/AsmPrinter/-AsmPrinter/-DwarfCompileUnit.h2/2DwarfCompileUnit.cpp-DwarfDebug.h-DwarfDebug.cpp-DwarfFile.h-DwarfUnit.h-DwarfUnit.cpp-IR/-DIBuilder.cpp-Verifier.cpp-Linker/-IRMover.cpp-test/-Bitcode/-DIModule-fortran-external-module.ll-upgrade-cu-locals.ll-upgrade-cu-locals.ll.bc-CodeGen/Generic/-Generic/-DbgValueAggregate.ll-DebugInfo/-Generic/-import-inlined-declaration.ll-imported-name-inlined.ll-namespace.ll-split-dwarf-local-import.ll-split-dwarf-local-import2.ll2/2split-dwarf-local-import3.ll-verifier-invalid-disubprogram.ll-X86/-dimodule-external-fortran.ll-dwarfdump-DIImportedEntity_elements.ll-fission-inline.ll-fission-local-import.ll-fission-no-inline-gsym.ll-lexical-block-file-inline.ll-namelist2.ll-omit-empty.ll-Linker/-pr26037.ll-ThinLTO/X86/-X86/-debuginfo-cu-import.llHide PanelfKeyboard Reference? Differential D144004 Authored by dzhidzhoev on Feb 14 2023, 6:23 AM.Download Raw DiffReviewers sscalponedblaikiejmmartinezelliskrisb Commits rG06a0ae652497: Reland "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local…rGd80fdc6fc1a6: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported…rGed578f02cf44: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported…rGd04452d54829: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported… Repository rG LLVM Github Monorepo Event Timelinekrisb created this revision.Herald added a reviewer: sscalpone. Herald added a project: Restricted Project. Herald added subscribers: ormris, steven_wu, hiraditya. Harbormaster completed remote builds in B213644: Diff 497297.krisb added a parent revision: D143985: [DwarfDebug] Move emission of imported entities from beginModule() to endModule() (2/7).krisb added a child revision: D144005: [DwarfDebug] Move emission of types from beginModule() to endModule() (7/7).krisb mentioned this in D143985: [DwarfDebug] Move emission of imported entities from beginModule() to endModule() (2/7).krisb published this revision for review.krisb edited the summary of this revision. (Show Details)krisb added reviewers: dblaikie, jmmartinez, ellis.krisb added projects: Restricted Project, debug-info.Herald added a project: Restricted Project. Herald added subscribers: llvm-commits, cfe-commits. Comment Actionsllvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp 1117–1119 1692–1695 llvm/test/DebugInfo/Generic/split-dwarf-local-import3.ll 18–37Comment Actionsllvm/test/DebugInfo/Generic/split-dwarf-local-import3.ll 18–37Harbormaster completed remote builds in B215514: Diff 499848.ykhatav added a subscriber: ykhatav.jmmartinez accepted this revision.This revision is now accepted and ready to land.Comment ActionsHarbormaster completed remote builds in B219004: Diff 504605.Comment Actionsdzhidzhoev edited child revisions, added: D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7); removed: D144005: [DwarfDebug] Move emission of types from beginModule() to endModule() (7/7).Comment ActionsHarbormaster completed remote builds in B231970: Diff 522138.dzhidzhoev updated this revision to Diff 522254.Herald added subscribers: mattd, gchakrabarti, asavonic and 3 others. Harbormaster completed remote builds in B232053: Diff 522254.Comment ActionsHarbormaster completed remote builds in B232056: Diff 522257.Comment ActionsHarbormaster completed remote builds in B237122: Diff 529098.dzhidzhoev mentioned this in rG40b2eb62aa72: [DwarfDebug] Move emission of imported entities from beginModule() to endModule….This revision was landed with ongoing or failed builds.Closed by commit rGd04452d54829: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported… (authored by dzhidzhoev). This revision was automatically updated to reflect the committed changes.dzhidzhoev added a commit: rGd04452d54829: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported….dzhidzhoev added a reverting change: rGa7e7d34dc1ce: Revert "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local….dzhidzhoev added a commit: rGed578f02cf44: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported….dzhidzhoev added a reverting change: rG77f8f40cd492: Revert "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local….dzhidzhoev added a commit: rGd80fdc6fc1a6: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported….dzhidzhoev added a reverting change: rGfbdeb8cbc147: Revert "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local….dzhidzhoev added a commit: rG06a0ae652497: Reland "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local….FilesHistoryCommitsStackSimilarPathSizeclang/test/CodeGenCXX/debug-info-namespace.cpp41 linesllvm/include/llvm/IR/DIBuilder.h11 lineslib/Bitcode/Reader/MetadataLoader.cpp84 linesCodeGen/AsmPrinter/DwarfCompileUnit.h53 linesDwarfCompileUnit.cpp128 linesDwarfDebug.h18 linesDwarfDebug.cpp120 linesDwarfFile.h7 linesDwarfUnit.h4 linesDwarfUnit.cpp2 linesIR/DIBuilder.cpp20 linesVerifier.cpp8 linesLinker/IRMover.cpp34 linestest/Bitcode/DIModule-fortran-external-module.ll4 linesupgrade-cu-locals.ll118 linesupgrade-cu-locals.ll.bcCodeGen/Generic/DbgValueAggregate.ll4 linesDebugInfo/Generic/import-inlined-declaration.ll72 linesimported-name-inlined.ll14 linesnamespace.ll25 linessplit-dwarf-local-import.ll71 linessplit-dwarf-local-import2.ll40 linessplit-dwarf-local-import3.ll67 linesverifier-invalid-disubprogram.ll2 linesX86/dimodule-external-fortran.ll6 linesdwarfdump-DIImportedEntity_elements.ll4 linesfission-inline.ll4 linesfission-local-import.ll4 linesfission-no-inline-gsym.ll4 lineslexical-block-file-inline.ll4 linesnamelist2.ll4 linesomit-empty.ll6 linesLinker/pr26037.ll28 linesThinLTO/X86/debuginfo-cu-import.ll12 linesDiffIDBaseDescriptionCreatedLintUnitBaseBaseDiff 149729711b50b4Feb 14 2023, 6:23 AM★★Diff 249984811b50b4Apply review comments.Feb 23 2023, 7:16 AM★★Diff 3504605fe13393Rebase.Mar 13 2023, 5:30 AM★★Diff 4522138ae326c3Rebased.May 15 2023, 5:36 AM★★Diff 5522254f38878bFixed split-dwarf-local-import*.ll tests.May 15 2023, 10:29 AM★★Diff 6522257ae326c3Fixed split-dwarf-local-import*.ll tests.May 15 2023, 10:31 AM★★Diff 752909819146efAdded AutoUpdater, moving function-local imported entities belonging to…Jun 6 2023, 5:10 PM★★Diff 853170803de1cbrGd04452d54829cd7af5b43d670325ffa755ab0030Jun 15 2023, 5:29 AM★★StatusAuthorRevision AccepteddzhidzhoevD144005 [DwarfDebug] Move emission of types from beginModule() to endModule() (7/7) AccepteddzhidzhoevD144008 [DebugMetadata][DwarfDebug][CodeView] Support function-local static variables in lexical block scopes (6/7) AccepteddzhidzhoevD144007 [DwarfDebug] Move emission of globals from beginModule() to endModule() (5/7) CloseddzhidzhoevD144006 [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7) CloseddzhidzhoevD144004 [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7) CloseddzhidzhoevD143985 [DwarfDebug] Move emission of imported entities from beginModule() to endModule() (2/7) CloseddzhidzhoevD143984 [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7) CloseddzhidzhoevD158730 [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types CloseddzhidzhoevD155818 [CloneFunction][DebugInfo] Clone DISubprogram's local types D143967 [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF·Reviewers: yonghong-song, echristo, dblaikieMon, Dec 18, 5:08 PMThis file is larger than 256 KB, so syntax highlighting is disabled by default.This file was added.This binary file was added.This file was added.This file was added.This file was added.This file was added.