⚙ D25495 [ThinLTO] Avoid archive member collisions (original) (raw)

This is an archive of the discontinued LLVM Phabricator instance.

Table of Contentst-lld/trunk/-trunk/-ELF/-InputFiles.h-InputFiles.cpp-SymbolTable.cpp-Symbols.cpp-test/ELF/lto/-ELF/-lto/-Inputs/-thin1.ll-thin2.ll-thin-archivecollision.llHide PanelfKeyboard Reference? Differential D25495 Authored by davide on Oct 11 2016, 7:10 PM.Download Raw DiffReviewers ruiupcc Commits rGbcdd6c60a09b: [ThinLTO] Avoid archive member collisions.rLLD284034: [ThinLTO] Avoid archive member collisions.rL284034: [ThinLTO] Avoid archive member collisions. Repository rL LLVM Event Timelinedavide updated this revision to Diff 74318.davide retitled this revision from to [ThinLTO] Avoid archive member collisions.davide updated this object.davide added a reviewer: pcc.davide added a subscriber: llvm-commits.Herald added a subscriber: mehdi_amini. Comment ActionsComment ActionsComment ActionsComment ActionsELF/InputFiles.cpp 718 ↗(On Diff #74318)Comment Actionsruiu added a subscriber: ruiu.ruiu added inline comments.ELF/InputFiles.cpp 726–727 ↗(On Diff #74393)davide added inline comments.ELF/InputFiles.cpp 726–727 ↗(On Diff #74393)pcc added inline comments.ELF/InputFiles.cpp 726–727 ↗(On Diff #74393)Comment Actionsmehdi_amini added inline comments.ELF/InputFiles.cpp 726–727 ↗(On Diff #74393)davide updated this revision to Diff 74411.Comment ActionsComment ActionsComment ActionsComment ActionsComment ActionsComment ActionsComment ActionsELF/InputFiles.cpp 491 ↗(On Diff #74411)Comment ActionsELF/InputFiles.cpp 491 ↗(On Diff #74411)Comment ActionsThis revision is now accepted and ready to land.Comment Actionsruiu accepted this revision.ruiu added a reviewer: ruiu.Closed by commit rL284034: [ThinLTO] Avoid archive member collisions. (authored by davide). This revision was automatically updated to reflect the committed changes.Comment Actionspcc mentioned this in D29059: refactor COFF linker to use new LTO API.FilesHistoryCommitsPathSizelld/trunk/ELF/InputFiles.h14 linesInputFiles.cpp27 linesSymbolTable.cpp6 linesSymbols.cpp6 linestest/ELF/lto/Inputs/thin1.ll12 linesthin2.ll11 linesthin-archivecollision.ll25 linesDiffIDBaseDescriptionCreatedLintUnitBaseBaseDiff 174318Oct 11 2016, 7:07 PM★★Diff 274393Oct 12 2016, 9:13 AM★★Diff 374411Oct 12 2016, 11:49 AM★★Diff 474419Oct 12 2016, 12:36 PM★★Diff 574422284033rL284034Oct 12 2016, 12:35 PM★★