#11848 (THEME: discover – WordPress Themes (original) (raw)

#2 @sixhours

13 years ago

Theme Check

Required

• index.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Line 48:
Line 63:

Previous Issues

FIXED Themes are REQUIRED to use 'wp_title' filter, to filter wp_title()

Code

Required

• All theme options need to be properly escaped with the correct function; please see here:

​http://codex.wordpress.org/Theme_Review#Security_and_Privacy

• element-boxes.php, line 22 -- incorrect text domain, Hero should be discover
• element-slider.php, line 12 -- This dummy text is probably considered SEO-seeding (100% professional business theme sounds like keywords). I'd use something more generic, like lorem ipsum.
• The theme supports a custom logo option that effectively does the same thing as WordPress custom headers. If implementing custom headers, the theme must use WP core functionality rather than a theme option.
• footer.php, line 25 -- Credit text should be made translatable if you intend for the theme to be so
• image.php -- get_permalink() and wp_get_attachment_url() should be escaped with esc_url()
• options.php -- Please remove any unused "dummy" code
• template-blog.php, line 33 -- Need to esc_url() here

Recommended

• header.php -- I would remove the default "Home" link hard-coded into header.php and add a filter to the fallback menu instead (see _s for an example: ​https://github.com/Automattic/_s/blob/master/inc/extras.php), which allows users to choose their own menu selections under Appearance -> Menus and remove the Home link if desired.

Visual

Required

• Nested list items in widgets have bottom gaps due to bottom margins/padding
• On monthly archives page, Month and Year are missing a space between, ie. "May2013" instead of "May 2013"
• Author archives are missing the author name in the headline
• Page links appear on the same line as tags -- is this intentional?
• Search results not found could use a search form so users can more easily search again

Recommended

• DT/DD/ADDRESS tags could use an increase in line height to match the surrounding text and other elements
• When a custom background color is used, the content runs up against its container. I'd suggest adding some padding there.

Recommendation

Thanks for your submission! This was a complete review. There are a number of Required issues that should be addressed... please fix and resubmit your theme. If you can do so in the next 2-3 days, please post a link to the new ticket here and I'll be happy to re-review.

#3 @manish_gori

13 years ago

Hello Sir,

I have fixed all points except this:

All theme options need to be properly escaped with the correct function; please see here:

If you go to folder admin/options-sanitize.php does that? Please advise?

Thanks

#4 @sixhours

13 years ago

If you go to folder admin/options-sanitize.php does that? Please advise?

The Options Framework sanitizes on input, but you still need to use esc_url, esc_textarea, esc_attr, etc. functions around the output to ensure nothing gets through via filters or injections. The general rule is, don't trust any data going into the database, and don't trust any data coming out of the database.

#6 @sixhours

13 years ago

• Resolution set to closed-newer-version-uploaded
• Status changed from assigned to closed