#12356 (THEME: Venom – WordPress Themes (original) (raw)

Issues from previous review:

FIXED $content_width is set to 520 but is actually 642
FIXED sidebar.php, line 7 -- function_exists() check around dynamic_sidebar() needs to be removed; no backwards compatibility necessary for functions that are greater than 2 major WP revisions past.
FIXED sidebar.php -- no need to do if/else unless you're adding default content to the sidebar in the absence of assigned widgets. Just call dynamic_sidebar().
FIXED All theme options must be properly escaped before being used/output in the theme -- see:
​​http://codex.wordpress.org/Theme_Review#Security_and_Privacy
N/A All functions must be prefixed with the theme_slug_, found one in functions.php that is not yet prefixed
FIXED functions.php, line 298 -- must be escaped with esc_url()
FIXED functions.php, line 310 -- must remove backwards compatibility for functions > 2 major WP revisions past, register_sidebar has been around a while
FIXED functions.php, line 398 -- stylesheets should be hooked into wp_enqueue_scripts as well, not wp_print_styles.
FIXED Lacking a space after the colon in "Posted by:Author Name"
FIXED Categories and tags display oddly -- Tags headline is floated next to categories
FIXED Archives for date, tags, categories, etc. don't display a page headline, ie. "Archives for September 2008"
FIXED Select menus with long titles overflow the widget area -- needs a max-width rule
FIXED Table headings are unreadable due to low contrast between foreground and background colors
FIXED PRE and INS tags are unreadable due to low contrast between foreground and background colors
FIXED Select menus in widget areas are difficult to read due to low contrast between foreground and background colors

Contained the width of dropdown select but the long option is still overflowing, could not find any fix. If you have any suggestion regarding that, i will be happy to implement it.

No worries, this is normal; the long option should overflow, but the menu item itself should not. Looks good now!

Review based on Diff and a quick visual check; all looks good, marking as Approved!