#12380 (THEME: discover – WordPress Themes (original) (raw)

Issues from previous review:

FIXED All theme options need to be properly escaped with the correct function.
​FIXED element-boxes.php, line 22 -- incorrect text domain, Hero should be discover
FIXED element-slider.php, line 12 -- This dummy text is probably considered SEO-seeding (100% professional business theme sounds like keywords). I'd use something more generic, like lorem ipsum.
FIXED The theme supports a custom logo option that effectively does the same thing as WordPress? custom headers. If implementing custom headers, the theme must use WP core functionality rather than a theme option.
FIXED footer.php, line 25 -- Credit text should be made translatable if you intend for the theme to be so
FIXED image.php -- get_permalink() and wp_get_attachment_url() should be escaped with esc_url()
FIXED options.php -- Please remove any unused "dummy" code
NOT FIXED, see below... template-blog.php, line 33 -- Need to esc_url() here
FIXED Nested list items in widgets have bottom gaps due to bottom margins/padding
FIXED On monthly archives page, Month and Year are missing a space between, ie. "May2013" instead of "May 2013"
FIXED Author archives are missing the author name in the headline
FIXED Search results not found could use a search form so users can more easily search again

Required issues:
template-tags.php -- Still need to escape wp_get_attachment_image_src() with esc_url()

Review based on Diff and a quick visual check; one minor required issue can be addressed in the next release. Marking as Approved!