#21892 (THEME: Just Clean Shop – WordPress Themes (original) (raw)

#2 @themetracbot

11 years ago

#3 @themetracbot

11 years ago

#5 @karmatosed

11 years ago

Hi, you've got me as your mentor! I'm really looking forward to mentoring you and helping you become a theme reviewer. Most communication we can do in trac right here. I am available though on Slack in #themereview if you need me.

#6 follow-up: ↓ 7 @KalenJohnson

11 years ago

Hey guys,

Sorry I've been busy the last couple weeks. I'll try and get this theme reviewed this week.

#7 in reply to:↑ 6 @JustPX

11 years ago

Replying to KalenJohnson:

Hey guys,

Sorry I've been busy the last couple weeks. I'll try and get this theme reviewed this week.

Hello, I can help you?

#8 @KalenJohnson

11 years ago

Hi JustPX,

Good work on the theme, it's pretty clean and simple, I'm always happy to see that :)

Not too many issues, but here are a couple:

header.php
Line 10 - Please do not link directly to a jQuery CDN file. jQuery should be enqueued using WordPress:
​https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts
"No hard coding of scripts, styles and Favicons unless a browser workaround script. Everything should be enqueued."

Line 11-25 - what does this script do? And why is it saved within a //<![CDATA[ ]]> tag? If you're not using this code, it should be removed. It should also go into a .js file if it is in use.

functions.php
Line 133 - Closing center tag is is a typo: </ceter>
Also, as a strong suggestion, the Wordpress Admin area is loaded as HTML5, so tags like <center> and <font> are deprecated in HTML5. Suggest using either inline styles, or ideally, load your own CSS file for your theme's pages.

Suggestions

These are not requirements to be accepted, but other things that could improve the quality of your theme.

header.php
May consider using HTML5 Doctype

functions.php
Line 79 - Unused variable $args, this could be removed.
Line 108 - Unused variable $defaults, this could be removed.

Let me know if you have any questions!

#9 follow-up: ↓ 13 @KalenJohnson

11 years ago

Whoops, @karmatosed, I think I should have set to "still reviewing" rather than "not approved". JustPX can still make the updates and have it approved.

#15 @emiluzelac

11 years ago