Issue 2644: errors from msync ignored in mmap_object_dealloc (original) (raw)

Created on 2008-04-16 16:30 by schmir, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg65553 - (view) Author: Ralf Schmitt (schmir) Date: 2008-04-16 16:30
mmapmodule.c's mmap_object_dealloc calls msync without checking for an error.
msg97573 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-01-11 05:02
Do you have a test case to reproduce the errors? I see that we call msync followed by munmap, neither one checked.
msg97583 - (view) Author: Ralf Schmitt (schmir) Date: 2010-01-11 09:14
No, I don't know how to provoke such an error other than passing illegal parameters..(or munmap'ing the mmap'ed area).
msg126414 - (view) Author: Ross Lagerwall (rosslagerwall) (Python committer) Date: 2011-01-17 17:24
I think this can be closed. msync() is only called in mmap.flush() and it is checked for an error.
msg126433 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-01-17 20:20
That was changed in r84950 from #2643.
History
Date User Action Args
2022-04-11 14:56:33 admin set github: 46896
2011-01-17 20:20:56 brian.curtin set status: open -> closednosy:schmir, brian.curtin, rosslagerwallmessages: + resolution: out of datestage: test needed -> resolved
2011-01-17 17:24:04 rosslagerwall set nosy: + rosslagerwallmessages: +
2010-01-11 09:14:09 schmir set messages: +
2010-01-11 05:59:56 brian.curtin set priority: normal
2010-01-11 05:02:22 brian.curtin set nosy: + brian.curtinmessages: + stage: test needed
2008-04-16 16:30:25 schmir create