Issue 6355: bogus NULL check in PyCapsule (original ) (raw ) Issue6355
Created on 2009-06-28 09:34 by bkramer , last changed 2022-04-11 14:56 by admin . This issue is now closed .
Files
File name
Uploaded
Description
Edit
capsulecompare.patch
bkramer,2009-06-28 09:34
proposed patch
Messages (2)
msg89769 - (view)
Author: Benjamin Kramer (bkramer)
Date: 2009-06-28 09:34
Objects/capsule.c contains the following code: if (!name1 |
!name2) { /* they're only the same if they're both NULL. */ return name2 == name2; } The result of this comparison will always be true. The comment says it should be 'name1 == name2'.
msg89777 - (view)
Author: Benjamin Peterson (benjamin.peterson) *
Date: 2009-06-28 16:24
Thanks for the patch! Fixed in r73618 .
History
Date
User
Action
Args
2022-04-11 14:56:50
admin
set
github: 50604
2009-06-28 16:24:15
benjamin.peterson
set
status: open -> closednosy: + benjamin.peterson messages: + resolution: fixed
2009-06-28 09:34:36
bkramer
create