Message 108186 - Python tracker (original) (raw)

On the principle the patch looks good. In practice, it lacks a call to PyBuffer_Release(&buffer) in the various error cases (before returning NULL). It also lacks some tests in Lib/test/test_array.py.

In 3.x unicode type was renamed to str and str to bytes, so fromunicode should become fromstring (or maybe fromstr to avoid confusion) and fromstring should become frombytes.

This should be discussed separately, perhaps on python-dev first.