Message 137740 - Python tracker (original) (raw)
If being pretty is the only reason for this choice, then I think that documenting the method as
method:: read([n])
is simpler and cleaner .
But you've got much more experience than me, so I won't argue any further :-)
There are contexts where it is easier to give the default argument than call the method without argument, though, and that's where I find None more intuitive than -1 :) Arguably it's not very important, though.
Can I use _PyIO_ConvertSsize_t? Or should I duplicate its functionality in mmapmodule.c?
I let Antoine answer that.
I'm not sure. This would require including iomodule.h, which is supposed to be private to the _io module. I think duplicating it is fine, since the code is probably simple anyway (I'm too lazy to take a look right now :-)).