Message 331430 - Python tracker (original) (raw)

Message331430

Author	xtreak
Recipients	Anthony Sottile, asottile, cjw296, michael.foord, xtreak
Date	2018-12-09.12:56:47
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	1544360207.27.0.788709270274.issue26704@psf.upfronthosting.co.za
In-reply-to

Content
Thanks @asottile for the patch. I think the original AttributeError is resolved with where they were silenced. It seems similar to though the exception occurs from mock instead of partial object as in . The fix was applied to 3.7+ and hence 3.6 was not fixed which enters security fix only mode shortly. The attached tests also pass on master and I think it will it be a good unittest addition to Lib/unittest/test/testmock/testwith.py (similar to ) that has a couple of nested with statements for the same attribute. Adding cjw296 to the list.

Content

Thanks @asottile for the patch. I think the original AttributeError is resolved with where they were silenced. It seems similar to though the exception occurs from mock instead of partial object as in . The fix was applied to 3.7+ and hence 3.6 was not fixed which enters security fix only mode shortly. The attached tests also pass on master and I think it will it be a good unittest addition to Lib/unittest/test/testmock/testwith.py (similar to ) that has a couple of nested with statements for the same attribute. Adding cjw296 to the list.

History
Date	User	Action	Args
2018-12-09 12:56:47	xtreak	set	recipients: + xtreak, cjw296, michael.foord, asottile, Anthony Sottile
2018-12-09 12:56:47	xtreak	set	messageid: 1544360207.27.0.788709270274.issue26704@psf.upfronthosting.co.za
2018-12-09 12:56:47	xtreak	link	issue26704 messages
2018-12-09 12:56:47	xtreak	create