Message 61733 - Python tracker (original) (raw)

Great, Ray.

I don't see any test cases for the nntp library in the Lib/test/ directory. How can we make sure it works on the buildbots?

Bill

On Jan 25, 2008 12:49 PM, Ray Chason <report@bugs.python.org> wrote:

Ray Chason added the comment:

Here's take 2.

The pre-patch NNTP class has a long and complicated constructor. Rather than duplicate this constructor in NNTP_SSL, the patch converts most of the NNTP class to a new class, NNTPBase, which takes an already-connected socket as a parameter. NNTP and NNTP_SSL both inherit NNTPBase and create that socket in their own respective ways.

Added file: http://bugs.python.org/file9286/python-nntps-patch-2.txt

---

Tracker <report@bugs.python.org> <http://bugs.python.org/issue1926>

---