Message 96995 - Python tracker (original) (raw)

Gregory P. Smith wrote:

Gregory P. Smith <greg@krypto.org> added the comment:

lemburg - see which issue #?

Sorry, the message got truncated for some reason.

I was referring to http://bugs.python.org/issue3745

This was discussed on python-dev: http://mail.python.org/pipermail/python-dev/2009-December/094593.html

Anyways perhaps the right thing to do instead of trunk r65961 would have been to change the s# to an s*.

That would have worked as well.

Undoing it will be more painful now as several changes have gone in since that require undoing and possibly redoing differently.

Using s* should pretty much avoid the need to use GET_BUFFER_VIEW_OR_ERROUT(), so if you want to keep the other changes, removing the use of the macro should be fairly straight-forward, unless I'm missing something.