Message 97659 - Python tracker (original) (raw)

Some comments:

• you should probably write n = sys.maxsize instead of n = 1 << 31 - 1
• ZipExtFile.read() should support n=None as a synonym to n=-1 (read everything)
• bytes as a variable name isn't very good since it's the built-in name for bytestrings in py3k
• in ZipExtFile.read(), it seems you have removed the adjustment for encrypted files (see adjust read size for encrypted files since the first 12 bytes [etc.])
• is there a situation where the decompressor might return less bytes than expected? (after all compression doesn't /always/ compress, in unfavourable chunks of data it might actually expand things a bit)