Joseph S. Myers - Re: PATCH RFC: -Wstrict-overflow (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "Joseph S. Myers"
• To: Ian Lance Taylor
• Cc: gcc-patches at gcc dot gnu dot org
• Date: Thu, 1 Feb 2007 13:57:23 +0000 (UTC)
• Subject: Re: PATCH RFC: -Wstrict-overflow
• References: <m34pq6vaxj.fsf@localhost.localdomain>

On Thu, 31 Jan 2007, Ian Lance Taylor wrote:

+static void +fold_overflow_warning (const char* warnmsg) +{

This parameter should be called "gmsgid" so that strings passed to this function are extracted for translation; see ABOUT-GCC-NLS.

•  const char * const warnmsg = ("assuming signed overflow is "

•            "undefined when negating a division");

• const char * const warnmsg = ("assuming signed overflow is undefined when "

•         "folding range test");

•  const char * const warnmsg = ("assuming signed overflow is undefined "

•             "when combining constants around a "

•             "comparison");

Strings such as these not directly appearing as arguments called "*msgid" need to be marked with G_() so that they are extracted for translation.

-- Joseph S. Myers joseph@codesourcery.com

• Follow-Ups:
  • Re: PATCH RFC: -Wstrict-overflow
    * From: Ian Lance Taylor
• References:
  • PATCH RFC: -Wstrict-overflow
    * From: Ian Lance Taylor