Ian Lance Taylor - Re: [PATCH] Fix ICE on sprintf (p, "%s") and miscompilation of sprintf ( (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

Re: [PATCH] Fix ICE on sprintf (p, "%s") and miscompilation of sprintf (p, "a", q++) (PR middle-end/30473)

• From: Ian Lance Taylor
• To: Jakub Jelinek
• Cc: gcc-patches at gcc dot gnu dot org
• Date: 01 Feb 2007 14:26:14 -0800
• Subject: Re: [PATCH] Fix ICE on sprintf (p, "%s") and miscompilation of sprintf (p, "a", q++) (PR middle-end/30473)
• References: <20070201133323.GG27294@devserv.devel.redhat.com>

Jakub Jelinek jakub@redhat.com writes:

BTW, I noticed we do all the fold_builtin_1 folding even with -O0, is that desirable? Might make debugging harder.

I think we should fold __builtin_FN, and in some cases that is necessary. But I agree that something like sprintf should not be folded at -O0. Anybody want to implement that?

• arglist = TREE_CHAIN (TREE_CHAIN (arglist));

Please use a new variable here, e.g., third_argument, rather than reusing arglist. New variables are fairly cheap, and I think it will make the rest of the patch more comprehensible.

I assume you bootstrapped it--you didn't say.

OK with that change for all open branches.

Thanks.

Ian

• Follow-Ups:
  • Re: [PATCH] Fix ICE on sprintf (p, "%s") and miscompilation of sprintf (p, "a", q++) (PR middle-end/30473)
    * From: Jakub Jelinek
• References:
  • [PATCH] Fix ICE on sprintf (p, "%s") and miscompilation of sprintf (p, "a", q++) (PR middle-end/30473)
    * From: Jakub Jelinek