Tobias Burnus - Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/m (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Tobias Burnus
• To: Brooks Moses
• Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
• Date: Fri, 02 Feb 2007 13:41:28 +0100
• Subject: Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)
• References: <45C1ABEF.1080207@net-b.de> <20070201195551.GA4084@meiner.onlinehome.de> <45C2FC38.70502@net-b.de> <45C30C0C.5060900@codesourcery.com>

Hi,

Brooks Moses wrote:

This is why it's helpful for people to actually explain the differences they're suggesting! Well, in this case it lead to a better comment. (I will use your version.)

Also, I just noticed -- in your libgfortran patches, you end up using -HUGE-1 for both integers and reals. I presume on reals that just ends up being the same as -HUGE?

I should have check this part better :-/ As m4 illiterate, I don't know how to fix this properly (I will try to find out nonetheless); seemingly the following line by Thomas didn't work:

define(atype_min,ifelse(rtype_letter,i',(-'atype_max-1)',-'atype_max))dnl

and possibly the following ifs don't work either:

m4/pow.m4:ifelse(rtype_letter,i,dnl m4/iparm.m4:define(rtype_ccode,ifelse(rtype_letter,i',rtype_kind,rtype_code))dnl

(In the first case it is i, in the second it is `i' is this intended?)

Tobias

• References:
  • [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)
    * From: Tobias Burnus
  • Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)
    * From: Thomas Koenig
  • Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)
    * From: Tobias Burnus
  • Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)
    * From: Brooks Moses