Jagasia, Harsha - RE: [patch] tuning gcc for AMDFAM10 processor (patches 4 to 11) (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "Jagasia, Harsha"
• To: "Roger Sayle"
• Cc: gcc-patches at gcc dot gnu dot org
• Date: Fri, 2 Feb 2007 17:59:00 -0600
• Subject: RE: [patch] tuning gcc for AMDFAM10 processor (patches 4 to 11)

Modifying the ChangeLog as per GNU style guidelines.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (athlon_ssedivvector_amdfam10,
    athlon_ssedivvector_load_amdfam10, athlon_ssemulvector_amdfam10,
    athlon_ssemulvector_load_amdfam10): New define_insn_reservation.
    (athlon_ssediv, athlon_ssediv_load_k8, athlon_ssemul,
    athlon_ssemul_load_k8): Added amdfam10.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (cvtss2sd_load_amdfam10,
    cvtss2sd_amdfam10, cvtps2pd_load_amdfam10, cvtps2pd_amdfam10,
    cvtsi2sd_load_amdfam10, cvtsi2ss_load_amdfam10,
    cvtsi2sd_amdfam10, cvtsi2ss_amdfam10, cvtsd2ss_load_amdfam10,
    cvtsd2ss_amdfam10, cvtpd2ps_load_amdfam10, cvtpd2ps_amdfam10,
    cvtsX2si_load_amdfam10, cvtsX2si_amdfam10): New
    define_insn_reservation.

    * config/i386/sse.md (cvtsi2ss, cvtsi2ssq, cvtss2si,
    cvtss2siq, cvttss2si, cvttss2siq, cvtsi2sd, cvtsi2sdq,
    cvtsd2si, cvtsd2siq, cvttsd2si, cvttsd2siq,
    cvtpd2dq, cvttpd2dq, cvtsd2ss, cvtss2sd,
    cvtpd2ps, cvtps2pd): Added amdfam10_decode attribute.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (sselog_load_amdfam10, sselog_amdfam10,
    ssecmpvector_load_amdfam10, ssecmpvector_amdfam10,
    ssecomi_load_amdfam10, ssecomi_amdfam10,
    sseaddvector_load_amdfam10, sseaddvector_amdfam10): New
    define_insn_reservation.
    (ssecmp_load_k8, ssecmp, sseadd_load_k8, seadd): Added amdfam10.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (athlon_sseins_amdfam10): New
    define_insn_reservation.
    * config/i386/i386.md (sseins): Added sseins to define_attr type
    and define_attr unit.
    * config/i386/sse.md: Set type attribute to sseins for insertq
    and insertqi.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (athlon_sseld_amdfam10,
    athlon_mmxld_amdfam10, athlon_ssest_amdfam10,
    athlon_mmxssest_short_amdfam10): New define_insn_reservation.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (athlon_call_amdfam10,
    athlon_pop_amdfam10, athlon_lea_amdfam10): New
    define_insn_reservation.
    (athlon_branch, athlon_push, athlon_leave_k8, athlon_imul_k8,
    athlon_imul_k8_DI, athlon_imul_mem_k8, athlon_imul_mem_k8_DI,
    athlon_idiv, athlon_idiv_mem, athlon_str): Added amdfam10.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/i386.md (x86_sahf_1, cmpfp_i_mixed, cmpfp_i_sse,
    cmpfp_i_i387, cmpfp_iu_mixed, cmpfp_iu_sse, cmpfp_iu_387,
    swapsi, swaphi_1, swapqi_1, swapdi_rex64, fix_truncsfdi_sse,
    fix_truncdfdi_sse, fix_truncsfsi_sse, fix_truncdfsi_sse,
    x86_fldcw_1, floatsisf2_mixed, floatsisf2_sse, floatdisf2_mixed,
    floatdisf2_sse, floatsidf2_mixed, floatsidf2_sse,
    floatdidf2_mixed, floatdidf2_sse, muldi3_1_rex64, mulsi3_1,
    mulsi3_1_zext, mulhi3_1, mulqi3_1, umulqihi3_1, mulqihi3_insn,
    umulditi3_insn, umulsidi3_insn, mulditi3_insn, mulsidi3_insn,
    umuldi3_highpart_rex64, umulsi3_highpart_insn,
    umulsi3_highpart_zext, smuldi3_highpart_rex64,
    smulsi3_highpart_insn, smulsi3_highpart_zext, x86_64_shld,
    x86_shld_1, x86_64_shrd, sqrtsf2_mixed, sqrtsf2_sse,
    sqrtsf2_i387, sqrtdf2_mixed, sqrtdf2_sse, sqrtdf2_i387,
    sqrtextendsfdf2_i387, sqrtxf2, sqrtextendsfxf2_i387,
    sqrtextenddfxf2_i387): Added amdfam10_decode.

    * config/i386/athlon.md (athlon_idirect_amdfam10,
    athlon_ivector_amdfam10, athlon_idirect_load_amdfam10,
    athlon_ivector_load_amdfam10, athlon_idirect_both_amdfam10,
    athlon_ivector_both_amdfam10, athlon_idirect_store_amdfam10,
    athlon_ivector_store_amdfam10): New define_insn_reservation.
    (athlon_idirect_loadmov, athlon_idirect_movstore): Added
    amdfam10.

2007-02-02 Harsha Jagasia harsha.jagasia@amd.com

    * config/i386/athlon.md (athlon_fldxf_k8, athlon_fld_k8,
    athlon_fstxf_k8, athlon_fst_k8, athlon_fist, athlon_fmov,
    athlon_fadd_load, athlon_fadd_load_k8, athlon_fadd, athlon_fmul,
    athlon_fmul_load, athlon_fmul_load_k8, athlon_fsgn,
    athlon_fdiv_load, athlon_fdiv_load_k8, athlon_fdiv_k8,
    athlon_fpspc_load, athlon_fpspc, athlon_fcmov_load,
    athlon_fcmov_load_k8, athlon_fcmov_k8, athlon_fcomi_load_k8,
    athlon_fcomi, athlon_fcom_load_k8, athlon_fcom): Added amdfam10.

Thanks, Harsha

Hi Harsha,

On Mon, 29 Jan 2007, Jagasia, Harsha wrote:

    * gcc/gcc/config/i386/sse.md (cvtsi2ss, cvtsi2ssq,
    cvtss2si, cvtss2siq, cvttss2si, cvttss2siq,
    cvtsi2sd, cvtsi2sdq, cvtsd2si, cvtsd2siq,
    cvttsd2si, cvttsd2siq, cvtpd2dq, cvttpd2dq
    cvtsd2ss, cvtss2sd, cvtpd2ps, cvtps2pd):added
    amdfam10_decode attribute

The descriptive text in a ChangeLog entry should be a well-formed sentence, i.e. start with a capital letter and end with a period/ full-stop. And in the example quoted above you need a space between the colon and the first letter of the description. It seems that the first patches in the series follow these GNU style guidelines, but by the end the "added amdfam10" (which should be "Added amdfam10.") seems to have become more prevalent.

    * gcc/gcc/config/i386/athlon.md (athlon_sseins_amdfam10
    ): new define_insn_reservation

    * gcc/gcc/config/i386/i38.md (sseins: added sseins to
    define_attr type and define_attr unit

In the first "entry", you should probably wrap the line after "):" and in the second you're missing a close parenthesis after "sseins". In both, the filenames should begin at "* config/i386/..." as the filenames and paths in ChangeLog entries should be relative to the ChangeLog itself. In this case, these are in gcc/gcc/ChangeLog.

Something like:

    * config/i386/athlon.md (athlon_sseins_amdfam10):
    New define_insn_reservation.

    * config/i386/i38.md (sseins): Added sseins to
    define_attr type and define_attr unit.

These mistakes are repeated multiple times in your ChangeLog entries.

I hope this helps.

Roger