John David Anglin - Re: [PATCH] Make global file function names link unique (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "John David Anglin"
• To: iant at google dot com (Ian Lance Taylor)
• Cc: geoffk at apple dot com, gcc-patches at gcc dot gnu dot org
• Date: Sat, 3 Feb 2007 16:24:15 -0500 (EST)
• Subject: Re: [PATCH] Make global file function names link unique

This patch seems equivalent to the one line patch: if (DECL_WEAK (decl) || DECL_ONE_ONLY (decl) || flag_shlib)

I'll approve that patch, if it works, and if it passes bootstrap and testsuite.

After testing on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11 with full bootstraps and checks, I committed the change below.

Dave

J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602)

2007-02-03 John David Anglin dave.anglin@nrc-cnrc.gc.ca

PR middle-end/30174
* varasm.c (notice_global_symbol): Treat global objects as weak when
flag_shlib is true.

Index: varasm.c

--- varasm.c (revision 121524) +++ varasm.c (working copy) @@ -1323,7 +1323,7 @@

/* We win when global object is found, but it is useful to know about weak symbol as well so we can produce nicer unique names. */

• if (DECL_WEAK (decl) || DECL_ONE_ONLY (decl))

• if (DECL_WEAK (decl) || DECL_ONE_ONLY (decl) || flag_shlib) type = &weak_global_object_name;

  if (!*type)