Richard Kenner - Re: [PATCH] Remove TREE_COMPLEXITY, take 2 (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
• To: paolo dot bonzini at lu dot unisi dot ch
• Cc: gcc-patches at gcc dot gnu dot org, stevenb dot gcc at gmail dot com
• Date: Mon, 05 Feb 2007 08:09:01 EST
• Subject: Re: [PATCH] Remove TREE_COMPLEXITY, take 2
• References: <45C7265F.6090500@lu.unisi.ch>

Thanks for taking care of this.

I found that the required hash table functions are actually already present in tree.c. There we have an implementation of a tree -> unsigned short hash table; we need tree -> unsigned int instead but it is not a problem to widen the values' type.

That's probably correct, but who are the other users of that table? I'm concerned about the size expansion.

Since Richard K. is a GWP, and since by now TREE_COMPLEXITY is an Ada-only thing (gigi-only) I placed in this patch also the actual removal of TREE_COMPLEXITY.

Has the OpenMP usage been removed? I haven't been able to keep track of of all of the back-and-forth on that issue.

The ada/decl.c change seems fine.

• Follow-Ups:
  • Re: [PATCH] Remove TREE_COMPLEXITY, take 2
    * From: Jakub Jelinek
• References:
  • [PATCH] Remove TREE_COMPLEXITY, take 2
    * From: Paolo Bonzini