Ian Lance Taylor - Change to gcc/config/i386/emmintrin.h (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Ian Lance Taylor
• To: gcc-patches at gcc dot gnu dot org
• Date: 06 Feb 2007 08:33:19 -0800
• Subject: Change to gcc/config/i386/emmintrin.h

Hi, you committed a change to gcc/config/i386/emmintrin.h:

-#ifdef SSE2 +#ifndef SSE2 +# error "SSE2 instruction set not enabled" +#else + +/* We need definitions from the SSE header files*/

There is no ChangeLog entry for this change. The log entry in subversion does not include the ChangeLog entry--it just says "amdfam10", which is uninformative. I would expect a change to emmintrin.h to be independent of scheduling changes for the amdfam10, and ideally proposed and submitted separately.

This change appears to be causing a number of tests in gcc.target/i386 to break when configured for i686-pc-linux-gnu. In gcc.log, I see lines like the appended.

Please fix these problems.

Thanks.

Ian

Executing on host: /home/iant/gcc/bootstrap/gcc/xgcc -B/home/iant/gcc/bootstrap/gcc/ /home/iant/gcc/trunk/gcc/testsuite/gcc.target/i386/pr13366.c -O -msse -fno-show-column -S -o pr13366.s (timeout = 300) In file included from /home/iant/gcc/bootstrap/gcc/include/xmmintrin.h:1245, from /home/iant/gcc/trunk/gcc/testsuite/gcc.target/i386/pr13366.c:4: /home/iant/gcc/bootstrap/gcc/include/emmintrin.h:34: error: #error "SSE2 instruction set not enabled" compiler exited with status 1 output is: In file included from /home/iant/gcc/bootstrap/gcc/include/xmmintrin.h:1245, from /home/iant/gcc/trunk/gcc/testsuite/gcc.target/i386/pr13366.c:4: /home/iant/gcc/bootstrap/gcc/include/emmintrin.h:34: error: #error "SSE2 instruction set not enabled"

FAIL: gcc.target/i386/pr13366.c (test for excess errors) Excess errors: In file included from /home/iant/gcc/bootstrap/gcc/include/xmmintrin.h:1245, from /home/iant/gcc/trunk/gcc/testsuite/gcc.target/i386/pr13366.c:4: /home/iant/gcc/bootstrap/gcc/include/emmintrin.h:34: error: #error "SSE2 instruction set not enabled"