Manuel López-Ibáñez - Re: [PING^3] Wconversion: fixes for C++ front-end (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

On 06/02/07, Paolo Carlini pcarlini@suse.de wrote:

Manuel López-Ibáñez wrote:

http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00799.html

Rediff, rebootstrapped and re-regression-tested against revision 121356 on i686-pc-linux-gnu.

Context and unified diffs follow.

Is there something I'm missing or the new testcase Wconversion-integer.C doesn't reflect the consensus resulting from the discussions in the audit trail of libstdc++/30464?!? Shall we wait a bit and add the final version of it???

This patch is months old (it's been in the patch queue since november). As you can see, it doesn't touch the warning logic (which is in c-common.c), it just updates places in the C++ front-end where convert_and_check should be called, but it wasn't. It also adds testcases for C++, some of them will work without this patch.

As for PR30464, I already have a patch (and I have already said this more than once) that addresses the concerns raised in PR30464. Since the patches are logically independent (apart from the testcases, that will need minor modifications), it makes sense to me to have Wconversion completed and then fine-tune it as requested in PR30464 as an incremental improvement (so each step makes sense on its own). I just didn't see the point on submitting the patch for PR30464 until the pending one was reviewed.

Cheers,Manuel.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]