John David Anglin - Re: PATCH: PR 29487 (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "John David Anglin"
• To: mark at codesourcery dot com
• Cc: gcc-patches at gcc dot gnu dot org, amylaar at gcc dot gnu dot org, danglin at gcc dot gnu dot org
• Date: Wed, 7 Feb 2007 00:47:26 -0500 (EST)
• Subject: Re: PATCH: PR 29487

If all goes well, I will check this in soon, and build GCC 4.1.2 RC2. Then, I will apply the same patch to 4.2 and mainline, with suitable changes, if required.

So far this is looking good. I had a successful build and check using COMDAT on HP-UX 11. It will take a while longer to confirm its behavior on HP-UX 10.

Comments?

I just have a couple of minor comments.

• instantiations is not pessimized. */

Extra whitespace in line.

• Exclude comdat functions from this rule.  While they can be bound

• to the other unit, they all must be the same.  This is especially

• important so templates can inline.  */

The above comment helped me understand why comdat functions have to be the same and shouldn't be replaceable (i.e., so templates can inline). The pessimization comment in tree.h seems vague.

--- gcc/testsuite/g++.dg/eh/weak1.C (revision 0) +++ gcc/testsuite/g++.dg/eh/weak1.C (revision 0) @@ -0,0 +1,22 @@ +// PR target/29487 +// { dg-do run } +// { dg-additional-sources "weak1-a.cc" }

Needs: // { dg-require-weak "" }

Dave

J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602)

• Follow-Ups:
  • Re: PATCH: PR 29487
    * From: John David Anglin
• References:
  • PATCH: PR 29487
    * From: Mark Mitchell