Gabriel Dos Reis - Re: [PING^3] Wconversion: fixes for C++ front-end (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

"Manuel López-Ibáñez" lopezibanez@gmail.com writes:

[...]

| Another problem is that I would need to encapsulate the warning logic | in convert_and_check on its own function, so it can be called from | convert_and_check and ocp_convert. That is fine except for the fact | that the C++ front-end already uses convert_and_check in a few places, | which in turn calls convert, which in turn calls ocp_convert, that | would generate warnings again. How could we fix this situation?

Make a list of all the places where the C++ front-end calls convert_and_check, document why. Make a list of all the places where the C++ front-end does not call convert_and_check (that is already contained in your patch). Document the differences in the "kinds" of conversions being checked in both cases. That should give you a good start.

-- Gaby

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]