Joseph S. Myers - Remove pex_write_input prototype (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "Joseph S. Myers"
• To: gcc-patches at gcc dot gnu dot org
• Date: Fri, 9 Feb 2007 15:31:52 +0000 (UTC)
• Subject: Remove pex_write_input prototype

A prototype for a function pex_write_input accidentally got added to include/libiberty.h a while back as part of another commit. There is however no such function in libiberty; an equivalent function was put in libiberty under the name pex_input_pipe.

I've applied this patch as obvious to mainline and 4.2 branch to remove the stray prototype from include/libiberty.h.

Index: ChangeLog

--- ChangeLog (revision 121753) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2007-02-09 Joseph S. Myers joseph@codesourcery.com + + * libiberty.h (pex_write_input): Remove prototype. + 2007-01-31 Vladimir Prus vladimir@codesourcery.com
* libiberty.h (PEX_STDERR_TO_PIPE): New define. Index: libiberty.h

--- libiberty.h (revision 121753) +++ libiberty.h (working copy) @@ -485,33 +485,6 @@ const char *outname, const char *errname, int err); -/ Return a FILE' pointer FP for the standard input of the first - program in the pipeline; FP is opened for writing. You must have - passed PEX_USE_PIPES' to the pex_init' call that returned OBJ. - You must close FP yourself with fclose' to indicate that the - pipeline's input is complete.

• The file descriptor underlying FP is marked not to be inherited by
• child processes.
• This call is not supported on systems which do not support pipes;
• it returns with an error. (We could implement it by writing a
• temporary file, but then you would need to write all your data and
• close FP before your first call to `pex_run' -- and that wouldn't
• work on systems that do support pipes: the pipe would fill up, and
• you would block. So there isn't any easy way to conceal the
• differences between the two types of systems.)
• If you call both pex_write_input' and pex_read_output', be
• careful to avoid deadlock. If the output pipe fills up, so that
• each program in the pipeline is waiting for the next to read more
• data, and you fill the input pipe by writing more data to FP, then
• there is no way to make progress: the only process that could read
• data from the output pipe is you, but you are blocked on the input
• pipe. */
• -extern FILE *pex_write_input (struct pex_obj *obj, int binary);
• /* Return a stream for a temporary file to pass to the first program in the pipeline as input. The file name is chosen as for pex_run. pex_run closes the file automatically; don't close it yourself. */

-- Joseph S. Myers joseph@codesourcery.com