Steve Kargl - Re: [FORTRAN, fix PR30478] Slightly overhaul ENUM parsing (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Steve Kargl
• To: Tobias Schl?ter
• Cc: Fortran List , gcc-patches
• Date: Sat, 10 Feb 2007 13:07:11 -0800
• Subject: Re: [FORTRAN, fix PR30478] Slightly overhaul ENUM parsing
• References: <45CE29CD.6090500@physik.uni-muenchen.de>

On Sat, Feb 10, 2007 at 09:23:41PM +0100, Tobias Schl?ter wrote:

and 4.1 once I manage to build and test this on all three versions? I can split out the cleanups, and only apply them to 4.3, in case they weren't included in Steve's whitespace works.

If there is a problem with the cleanups and 4.3, just include it in patch without splitting it out. I don't think splitting it out is worth the effort.

if (gfc_notify_std (GFC_STD_F2003, - "New in Fortran 2003: ENUM AND ENUMERATOR at %C") + "New in Fortran 2003: ENUM and ENUMERATOR at %C")

In 4.3 (and may be 4.2), we've dropped the "New in" portion of the error message. When you merge into 4.3, keep this in mind.

• if (initializer == NULL || initializer->ts.type != BT_INTEGER)
• {

•  gfc_error("ENUMERATOR %L not initialized with integer expression",

•   &var_locus);

Missing space after gfc_error.

Other than the above I think the patch is ok. You may want to see if FX has any comments.

-- Steve

• Follow-Ups:
  • Re: [FORTRAN, fix PR30478] Slightly overhaul ENUM parsing
    * From: FX Coudert
• References:
  • [FORTRAN, fix PR30478] Slightly overhaul ENUM parsing
    * From: Tobias Schlüter