Andrew Pinski - Re: PATCH: Build shared libraries with -Bsymbolic-functions (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Andrew Pinski
• To: hjl at lucon dot org (H. J. Lu)
• Cc: pinskia at physics dot uc dot edu (Andrew Pinski), aph at redhat dot com (Andrew Haley), paolo dot bonzini at lu dot unisi dot ch (Paolo Bonzini), gcc-patches at gcc dot gnu dot org
• Date: Sat, 10 Feb 2007 19:07:25 -0500 (EST)
• Subject: Re: PATCH: Build shared libraries with -Bsymbolic-functions

--pWyiEgJYm5f9v55/

BOOL objc_hash_is_key_in_hash (cache_ptr cache, const void *key);

is in hash.h and user can call it. It can't be hidden. But there is

[hjl@gnu-26 .libs]$ readelf --wide -r libobjc.so.2 | grep objc_hash_is_key_in_hash 0000000000217910 0000010700000007 R_X86_64_JUMP_SLOT 000000000000cde0 objc_hash_is_key_in_hash + 0

My approach will remove this relocation.

Again the benifit is little and useless for libobjc. Look at your numbers, only 100 saved which is small. I still an rejecting this patch, there are better ways of doing this issue in a generic way instead of changing all of target libraries.

-- Pinski

• References:
  • Re: PATCH: Build shared libraries with -Bsymbolic-functions
    * From: H. J. Lu