Steve Kargl - Re: [Patch, fortran] PR30554 (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

Re: [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

• From: Steve Kargl
• To: Paul Thomas
• Cc: Fortran List , gcc-patches
• Date: Sun, 11 Feb 2007 12:06:42 -0800
• Subject: Re: [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945
• References: <45CC65F6.2040102@wanadoo.fr> <20070211184544.GA21222@troutmask.apl.washington.edu> <45CF7558.7080601@wanadoo.fr>

On Sun, Feb 11, 2007 at 08:58:16PM +0100, Paul Thomas wrote:

Steve,

Thanks for the review. I'll put right the typos.

What do you think of the question of the one-liner that produces hidden symtrees, versus the more complicated patch that tries to recycle symtrees, if possible?

I prefer the more complicated patch. From a future maintenance standpoint (when pault isn't around), the hidden symtree approach may mislead one into thinking the hidden symtree has some magical importance. The more complicated approach and its comments in the code make it clear what is going on.

-- Steve

• Follow-Ups:
  • Re: [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945
    * From: Paul Thomas
• References:
  • [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945
    * From: Paul Thomas
  • Re: [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945
    * From: Steve Kargl
  • Re: [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945
    * From: Paul Thomas