Kaveh R. GHAZI - Re: [PATCH, i386]: Implement ldexp{,f,l} functions as built-in x87 int (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

On Sun, 11 Feb 2007, Uros Bizjak wrote:

Hello Kaveh!

Hi Uros,

By coincidence your ldexp patch was from exactly two years ago. :-)

I don't think you ever did the scalbn* refinement, and I think you could do scalbln* as well. Was there a technical reason you didn't proceed or you just forgot? I have a patch to do it, which I'm queuing until after Sandra's jumbo patch is installed. Please let me know.

The only reason is that I have totally forgot on this...

BTW: Looking at ChangeLog-2004, I see that you are the author of (long)round -> lround transformation in convert.c, convert_to_integer() function. Following your lead, I have added other conversions, but my last patch to convert (int)logb -> ilogb was rejected by middle-end maintainers on the ground that these transformations belong to fold-const.c. I was trying to move these transformations to their better place but failed miserably... do you have any ideas on how to move this thing?

Thanks, Uros.

Err, I was just following the path beaten by those who came before me: http://gcc.gnu.org/ml/gcc-patches/2002-11/msg00434.html http://gcc.gnu.org/ml/gcc-patches/2003-02/msg01451.html

What exactly did you try that failed? I'm guessing that the right place for this would be in fold_unary where it handles convert exprs. Peek into the operand and if it's the right combination of type and builtin then do the transformation. (?)

    --Kaveh

-- Kaveh R. Ghazi ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]