Seongbae Park - Re: [PATCH]: bitmap_and () causing inconsistent bitmap (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "Seongbae Park"
• To: "Ian Lance Taylor"
• Cc: gcc-patches
• Date: Tue, 13 Feb 2007 08:31:03 -0800
• Subject: Re: [PATCH]: bitmap_and () causing inconsistent bitmap
• References: <ab3a61990702112229v1337aee7n4d4e8bb7976598f6@mail.gmail.com> <m3hctq3v3d.fsf@localhost.localdomain>

On 13 Feb 2007 08:01:26 -0800, Ian Lance Taylor iant@google.com wrote:

"Seongbae Park" seongbae.park@gmail.com writes:

Index: ChangeLog

--- ChangeLog (revision 121840) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2007-02-11 Seongbae Park seongbae.park@gmail.com +

•   * bitmap.c (bitmap_and): Prevent stale current.

(Put the ChangeLog entry in the text of the e-mail, not in the patch. Thanks.)

Ok. Sorry about that.

+ /* This is to prevent stale current hanging. */

That's a little hard to understand. How about something like /* Ensure that dst->current is valid. */

Ok.

This is OK with that (or a similar) change.

It seems to me that these functions have the same problem: bitmap_and_compl, bitmap_ior, bitmap_xor. If you agree, please apply the same patch to those functions as well.

bitmap_ior doesn't seem to have this problem. But bitmap_and_compl and bitmap_xor definitely do. I'll commit the attached patch after retesting, if I don't get any more comment. Thanks for looking at the patch.

2007-02-13 Seongbae Park seongbae.park@gmail.com * bitmap.c (bitmap_and, bitmap_and_compl, bitmap_xor): Ensure dst->current is valid.

#pragma ident "Seongbae Park, compiler, http://seongbae.blogspot.com";

Attachment:bitmap.diff.txt
Description: Text document

• Follow-Ups:
  • Re: [PATCH]: bitmap_and () causing inconsistent bitmap
    * From: Seongbae Park
• References:
  • [PATCH]: bitmap_and () causing inconsistent bitmap
    * From: Seongbae Park
  • Re: [PATCH]: bitmap_and () causing inconsistent bitmap
    * From: Ian Lance Taylor