Steve Kargl - [PATCH] PR fortran/30799 - (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

[PATCH] PR fortran/30799 -- Fix missed invalid logical kinds

• From: Steve Kargl
• To: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
• Date: Wed, 14 Feb 2007 16:36:22 -0800
• Subject: [PATCH] PR fortran/30799 -- Fix missed invalid logical kinds

The patch should be self-explanatory, but why leave anything chance. For a bad kind parameter suffix on a logical constant, e.g., .TRUE._123, gfortran was check that 123 was valid, queue an error, and then procede without return a MATCH_ERROR. Thus, 123 was accepted as valid.

logical_2.f90 is a dejagnu-ified version of the reporters code.

Regression tested on x86_64-*-freebsd with no new failures.

OK for mainline and 4.2 (and 4.1 when re-opened)?

2007-02-14 Steven G. Kargl kargl@gcc.gnu.org

* primary.c (match_logical_constant): Return MATCH_ERROR on invalid kind.
* gfortran.dg/logical_2.f90: New test.

-- Steve

Attachment:primary.c.diff
Description: Text document

Attachment:logical_2.f90
Description: Text document

• Follow-Ups:
  • Re: [PATCH] PR fortran/30799 -- Fix missed invalid logical kinds
    * From: FX Coudert