Roman Zippel - Re: [m68k 04/13] libffi fixes and closure support (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Roman Zippel
• To: gcc-patches at gcc dot gnu dot org
• Cc: Andreas Schwab , law at redhat dot com
• Date: Sun, 18 Feb 2007 02:33:52 +0100
• Subject: Re: [m68k 04/13] libffi fixes and closure support
• References: 20070130112615.782382000@linux-m68k.org <1170786997.4134.74.camel@sweet.slc.redhat.com> <jehctzt67u.fsf@sykes.suse.de>

Hi,

On Tuesday 06 February 2007 20:51, Andreas Schwab wrote:

Can someone more familiar with libffi step in, please?

Looks ok to me, except that the changelog entry needs to be fixed to conform to the standards.

2007-01-30 Roman Zippel zippel@linux-m68k.org

* libffi/src/m68k/ffi.c (ffi_prep_args,ffi_prep_cif_machdep): Fix
numerous test suite failures.
* libffi/src/m68k/sysv.S (ffi_call_SYSV): Likewise.

* libffi/src/m68k/ffi.c (ffi_prep_incoming_args_SYSV)
(ffi_closure_SYSV_inner, ffi_prep_closure): New, add closure
support.
* libffi/src/m68k/sysv.S (ffi_closure_SYSV)
(ffi_closure_struct_SYSV): Likewise.

Ok to commit with fixed Changelog?

bye, Roman

• References:
  • Re: [m68k 04/13] libffi fixes and closure support
    * From: Jeffrey Law
  • Re: [m68k 04/13] libffi fixes and closure support
    * From: Andreas Schwab