Andrew Pinski - Re: [PATCH] Fix PR30978, forwprop not fully propagating conditionals (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: "Andrew Pinski"
• To: "Richard Guenther"
• Cc: gcc-patches at gcc dot gnu dot org
• Date: Tue, 27 Feb 2007 08:23:57 -0800
• Subject: Re: [PATCH] Fix PR30978, forwprop not fully propagating conditionals
• Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DlwimV0pfLiOzjWu/oEc+6zeKq8IoIBPENkTj/iP95jBpeJlMfrRl3afTXMIz/gT8Gi99JvHfbe4Ih9JusXecVDi17McfN4QLAcbIwrBlZIo6zQ2mNZIVg+Sh38JSNdd3oTJFZTGMYvHP3gH033oiFOaWQF4m9tL3ZmGAZ97QCI=
• References: <Pine.LNX.4.64.0702271712320.19680@zhemvz.fhfr.qr>

On 2/27/07, Richard Guenther rguenther@suse.de wrote:

This fixes PR30978 to lay grounds for a fix for PR30965 (failing to tree-combine conditions).

I would not have add an option and would have changed the testcase testsuite/gcc.dg/tree-ssa/ssa-fre-4.c to use char instead of _Bool. And now forwprop is getting too big for its own good really. Fold even does not do all of the optimizations that forwprop does (though it does the above one, I know because I had to add it).

It is better for you and your time instead of keep on adding stuff to forwprop to write a real tree combiner that uses fold to fold the expressions and then just improve fold instead.

Thanks, Andrew Pinski

• Follow-Ups:
  • Re: [PATCH] Fix PR30978, forwprop not fully propagating conditionals
    * From: Richard Guenther
• References:
  • [PATCH] Fix PR30978, forwprop not fully propagating conditionals
    * From: Richard Guenther