Dominique d'Humières - Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c (original) (raw)

This is the mail archive of the gcc-patches@gcc.gnu.orgmailing list for the GCC project.

• From: Dominique d'Humières
• To: gcc-patches Patches
• Date: Mon, 9 Feb 2015 20:40:17 +0100
• Subject: Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c
• Authentication-results: sourceware.org; auth=none
• References: <20150209172300 dot E2860105 at mailhost dot lps dot ens dot fr> <54D8F819 dot 9030709 at mentor dot com>

Le 9 févr. 2015 à 20:01, Dominique d'Humières dominiq@lps.ens.fr a écrit :

Le 9 févr. 2015 à 19:10, Tom de Vries Tom_deVries@mentor.com a écrit :

On 09-02-15 18:23, Dominique Dhumieres wrote:

Tom,

After these changes I have the following regressions on x86_64-apple-darwin1[04]*:

FAIL: gcc.dg/uninit-19.c (test for warnings, line 22) FAIL: gcc.dg/uninit-19.c (test for excess errors) FAIL: gcc.dg/graphite/scop-19.c scan-tree-dump-times graphite "number of SCoPs: 0" 1

I can prepare and test a fix for darwin unless you beat me!

Dominique,

thanks for finding this.

I don't understand why this breaks. Why is fpic supposed to be different for darwin?

I don’t either, but the tests succeeds on darwin with the following patch

--- ../_clean/gcc/testsuite/gcc.dg/uninit-19.c 2015-02-09 11:38:40.000000000 +0100 +++ gcc/testsuite/gcc.dg/uninit-19.c 2015-02-09 19:52:26.000000000 +0100 @@ -22,5 +22,5 @@ fn2 () fn1 (l, &d, &e, &g, &i, &h, &k, n); /* 22. */ }

-/* { dg-warning "may be used uninitialized" "" { target nonpic } 13 } / -/ { dg-warning "may be used uninitialized" "" { target { ! nonpic } } 22 } / +/ { dg-warning "may be used uninitialized" "" { target { nonpic || x86_64-apple-darwin1[0-9]* } } 13 } / +/ { dg-warning "may be used uninitialized" "" { target { ! { nonpic || x86_64-apple-darwin1[0-9]* } } } 22 } / --- ../_clean/gcc/testsuite/gcc.dg/graphite/scop-19.c 2015-02-09 11:38:40.000000000 +0100 +++ gcc/testsuite/gcc.dg/graphite/scop-19.c 2015-02-09 19:55:38.000000000 +0100 @@ -31,7 +31,7 @@ d_growable_string_append_buffer (struct if (need > dgs->alc) d_growable_string_resize (dgs, need); } -/ { dg-final { scan-tree-dump-times "number of SCoPs: 0" 2 "graphite" { target nonpic } } } / -/ { dg-final { scan-tree-dump-times "number of SCoPs: 0" 1 "graphite" { target { ! nonpic } } } } / +/ { dg-final { scan-tree-dump-times "number of SCoPs: 0" 2 "graphite" { target { nonpic || x86_64-apple-darwin1[0-9]* } } } } / +/ { dg-final { scan-tree-dump-times "number of SCoPs: 0" 1 "graphite" { target { ! { nonpic || x86_64-apple-darwin1[0-9]* } } } } } / / { dg-final { cleanup-tree-dump "graphite" } } */

Cheers,

Dominique

Thanks,

• Tom

• Follow-Ups:
  • Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c
    * From: Jack Howarth
• References:
  • Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c
    * From: Dominique Dhumieres
  • Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c
    * From: Tom de Vries