Property-based Creator clobbers enclosing value's JsonParser.currentValue() (original) (raw)

Jackson 3 Deserialization issues with Spring Boot Plugin

Repo to reproduce the issue: deskoh/jackson-issue

To reproduce the issue, run the tests

Jackson 3 using custom deserializer of a JSON with nested object will throw an exception.

tools.jackson.databind.DatabindException: class com.deskoh.entities.SourceSystem cannot be cast to class com.deskoh.entities.Project (com.deskoh.entities.SourceSystem and com.deskoh.entities.Project are in unnamed module of loader 'app') at [Source: REDACTED (StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION disabled); byte offset: FasterXML/jackson-core#119] (through reference chain: com.deskoh.entities.Project["assets"]) at app//tools.jackson.databind.DatabindException.wrapWithPath(DatabindException.java:111) at app//tools.jackson.databind.deser.bean.BeanDeserializerBase.wrapAndThrow(BeanDeserializerBase.java:1936) at app//tools.jackson.databind.deser.bean.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:654) at app//tools.jackson.databind.deser.bean.BeanDeserializer.deserialize(BeanDeserializer.java:200) at app//tools.jackson.databind.deser.DeserializationContextExt.readRootValue(DeserializationContextExt.java:266) at app//tools.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:2639) at app//tools.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:1622) at app//com.deskoh.entities.ProjectTest.given_project_can_deserialize(ProjectTest.java:24) Caused by: java.lang.ClassCastException: class com.deskoh.entities.SourceSystem cannot be cast to class com.deskoh.entities.Project (com.deskoh.entities.SourceSystem and com.deskoh.entities.Project are in unnamed module of loader 'app') at com.deskoh.entities.AssetDeserializer.deserialize(AssetDeserializer.java:19) at com.deskoh.entities.AssetDeserializer.deserialize(AssetDeserializer.java:13) at tools.jackson.databind.deser.impl.MethodProperty.deserializeAndSet(MethodProperty.java:120) at tools.jackson.databind.deser.bean.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:652) ... 5 more

Cause

The exception is thrown during custom deserialization.

// src\main\java\com\deskoh\entities\AssetDeserializer.java // p.currentValue() will evaluate to SourceSystem instead of Project Project project = (Project) p.currentValue();

However, the deserialization will work (and unit test pass) if either

1. -parameters flag is removed during compilation, OR

   Note: Adding org.springframework.boot gradle plugin will enable the -parameters flag --as well.
   tasks.withType(JavaCompile).configureEach {

• options.compilerArgs << "-parameters"

} 2. AllArgsConstructor of SourceSystem is removed, OR

Note: Similar behaviour with lombok @AllArgsConstructor annotation
public class SourceSystem {

• public SourceSystem(String id, String name) {

•   this.id = id;  

•   this.name = name;  

• }
  }

1. Jackson 2 is used (see jackson2 branch)