Breaking change: SetQueryParam appears to always encode spaces as pluses in v2.5.2 (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

tmenier / Flurl Public

Additional navigation options

Closed

Closed

Breaking change: SetQueryParam appears to always encode spaces as pluses in v2.5.2

#258

Labels

bug

Milestone

Flurl 2.6

@michael-wolfenden

Description

@michael-wolfenden

michael-wolfenden

opened

on Dec 18, 2017

The following

"https://www.google.com" .SetQueryParam("utm_source", "some source") .ToString()

Returns the following results

Flurl v2.5.2 Flurl v2.5.1
https://www.google.com?utm_source=some+source https://www.google.com?utm_source=some%20source

I get the same results even if encodeSpaceAsPlus is set to false

var encodeSpaceAsPlus = false

"https://www.google.com" .SetQueryParam("utm_source", "some source") .ToString(encodeSpaceAsPlus)

Returns the following results

Flurl v2.5.2 Flurl v2.5.1
https://www.google.com?utm_source=some+source https://www.google.com?utm_source=some%20source

Metadata

Metadata

Assignees

No one assigned

Labels

bug

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions