Breaking change: SetQueryParam appears to always encode spaces as pluses in v2.5.2 (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Notifications You must be signed in to change notification settings
Additional navigation options
Closed
Closed
Breaking change: SetQueryParam appears to always encode spaces as pluses in v2.5.2
#258
Labels
Milestone
Description
opened
The following
"https://www.google.com" .SetQueryParam("utm_source", "some source") .ToString()
Returns the following results
| Flurl v2.5.2 | Flurl v2.5.1 |
|---|---|
| https://www.google.com?utm_source=some+source | https://www.google.com?utm_source=some%20source |
I get the same results even if encodeSpaceAsPlus is set to false
var encodeSpaceAsPlus = false
"https://www.google.com" .SetQueryParam("utm_source", "some source") .ToString(encodeSpaceAsPlus)
Returns the following results
| Flurl v2.5.2 | Flurl v2.5.1 |
|---|---|
| https://www.google.com?utm_source=some+source | https://www.google.com?utm_source=some%20source |
Metadata
Metadata
Assignees
No one assigned
Labels
Projects
No projects
Milestone
Relationships
None yet
Development
No branches or pull requests